On Mon, Sep 22, 2014 at 2:48 PM, Paolo Bonzini <[email protected]> wrote:
> Il 22/09/2014 22:26, Andres Lagar-Cavilla ha scritto:
>> + __entry->gfn = gfn;
>> + __entry->hva = ((gfn - slot->base_gfn) >>
>
> This must be <<.
Correct, thanks.
>
>> + PAGE_SHIFT) + slot->userspace_addr;
>
>> + /*
>> + * No need for _notify because we're called within an
>> + * mmu_notifier_invalidate_range_ {start|end} scope.
>> + */
>
> Why "called within"? It is try_to_unmap_cluster itself that calls
> mmu_notifier_invalidate_range_*, so "we're within an
> mmu_notifier_invalidate_range_start/end scope" sounds better, and it's
> also what you use in the commit message.
Also correct. V4...
Andres
>
> Paolo
--
Andres Lagar-Cavilla | Google Kernel Team | [email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
