On Wed, Sep 24, 2014 at 10:59:21AM -0600, Jason Gunthorpe wrote: > On Wed, Sep 24, 2014 at 12:06:00PM +0300, Jarkko Sakkinen wrote: > > > - if (!(chip = tpm_register_hardware(dev, &tpm_tis))) > > + chip = tpm_chip_alloc(dev, &tpm_tis); > > + if (!chip) > > return -ENODEV; > > Please put this in a separate patch, don't co-mingle it with TPM2 > support. If drivers are going to be converted, then I want to see the > new API used properly and the driver itself to be a *correct* example > of using the new API.
Agreed. > So you have to purge the tis_chips, fix the missing removal functions, > call unregister, fix the force probe path, etc. > > > chip->vendor.iobase = ioremap(start, len); > > Since this changes the ordering, can we devm this ioremap? Hmm... I was going to do that but forgot it. I'll add this to my backlog. > Jason /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
