On 09/27/14 19:50, Nicholas Krause wrote: > This removes the FIXME message and issue with reading in this driver before > resuming > in the function, sa1111_resume.
You need to explain why this makes any sense. Hint: it doesn't. > Signed-off-by: Nicholas Krause <yoc...@gmail.com> > --- > arch/arm/common/sa1111.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c > index e57d7e5..0c4b9a9 100644 > --- a/arch/arm/common/sa1111.c > +++ b/arch/arm/common/sa1111.c > @@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev) > > /* > * Ensure that the SA1111 is still here. > - * FIXME: shouldn't do this here. > */ > - id = sa1111_readl(sachip->base + SA1111_SKID); > if ((id & SKID_ID_MASK) != SKID_SA1111_ID) { > __sa1111_remove(sachip); > platform_set_drvdata(dev, NULL); > -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/