Hi!
> > > + __raw_writel(RSTMGR_MPUMODRST_CPU1,
> > > + rst_manager_base_addr + 0x10);
> >
> > Would it be possible to copy reset manager description struct from
> > u-boot and use it here, instead of raw offset?
>
> I will replace this 0x10 with a macro that reflects how the register is
> named in the register map.
That would be better than 0x10, but even better would be just copying
struct socfpga_reset_manager {
u32 status;
u32 ctrl;
u32 counts;
u32 padding1;
u32 mpu_mod_reset;
u32 per_mod_reset;
u32 per2_mod_reset;
u32 brg_mod_reset;
};
from u-boot. Unlike macros, structs have advantages that typos lead to
easier-to-see failure modes... (And they are easier to read/parse,
too).
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
