From: Antoine Tenart <[email protected]> Date: Fri, 3 Oct 2014 17:01:53 +0200
> Dan reported a possible signedness issue on the pxa168_eth driver. While > having a look at it, I came across a similar problem in the spider_net > driver. > > Here is one proposal to fix it. The first patch rework the > spider_net_set_mac() function by removing the spider_net_get_mac_address() > call and using memcpy() to set netdev->dev_addr (which is what's done in > lots of Ethernet drivers) and the second one fix the actual signedness > issue. > > If for any reason you really want to keep a call to > spider_net_get_mac_address() because the memcpy() is somehow not good > enough here, we can also come up with a solution involving a temporary > unsigned char variable. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
