On Fri 03-10-14 10:19:30, Heinrich Schuchardt wrote:
> The fanotify and the inotify API can used to monitor changes of the file
> system.
>
> System call fallocate modifies files. Hence it should trigger the
> corresponding
> fanotify (FAN_MODIFY) and inotify (IN_MODIFY) events.
>
> This patch adds the missing call to fsnotify_modify.
Well, there are different fallocate() commands and e.g. pure
FALLOC_FL_KEEP_SIZE call will not change any data in the file. I'm not sure
how much we care but I wanted to point that out...
Honza
> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
> ---
> fs/open.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/fs/open.c b/fs/open.c
> index d6fd3ac..03aa8e5 100644
> --- a/fs/open.c
> +++ b/fs/open.c
> @@ -295,6 +295,11 @@ int do_fallocate(struct file *file, int mode, loff_t
> offset, loff_t len)
>
> sb_start_write(inode->i_sb);
> ret = file->f_op->fallocate(file, mode, offset, len);
> +
> + /* Create inotify and fanotify events. */
> + if (ret == 0)
> + fsnotify_modify(file);
> +
> sb_end_write(inode->i_sb);
> return ret;
> }
> --
> 2.1.0
>
--
Jan Kara <j...@suse.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
