Hi Soren,
On 10/06/2014 05:59 PM, Sören Brinkmann wrote:
> Hi Michal,
>
> On Mon, 2014-10-06 at 01:44PM +0200, Michal Simek wrote:
>> Get OCM configuration from SLCR.
>>
>> Signed-off-by: Michal Simek <michal.si...@xilinx.com>
>> ---
>>
>> arch/arm/mach-zynq/slcr.c | 15 +++++++++++++++
>> include/soc/zynq/common.h | 1 +
>> 2 files changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/mach-zynq/slcr.c b/arch/arm/mach-zynq/slcr.c
>> index cb7c46165728..0c3e45090c09 100644
>> --- a/arch/arm/mach-zynq/slcr.c
>> +++ b/arch/arm/mach-zynq/slcr.c
>> @@ -27,6 +27,7 @@
>> #define SLCR_A9_CPU_RST_CTRL_OFFSET 0x244 /* CPU Software Reset Control */
>> #define SLCR_REBOOT_STATUS_OFFSET 0x258 /* PS Reboot Status */
>> #define SLCR_PSS_IDCODE 0x530 /* PS IDCODE */
>> +#define SLCR_OCM_CFG_OFFSET 0x910 /* OCM Address Mapping */
>>
>> #define SLCR_UNLOCK_MAGIC 0xDF0D
>> #define SLCR_A9_CPU_CLKSTOP 0x10
>> @@ -126,6 +127,20 @@ void zynq_slcr_system_reset(void)
>> }
>>
>> /**
>> + * zynq_slcr_get_ocm_config - Get SLCR OCM config
>> + *
>> + * Return: OCM config bits
>> + */
>> +u32 zynq_slcr_get_ocm_config(void)
>> +{
>> + u32 val;
>> +
>> + zynq_slcr_read(&val, SLCR_OCM_CFG_OFFSET);
>> +
>> + return val;
>> +}
>
> a different idea would be, instead of creating this specific API call
> for the OCMC to let the OCMC driver use regmap and making git a subnode
> of the SLCR.
> In the long run that might be a better option otherwise we'll end up
> with a whole bunch of zynq_slcr_get_foo() calls for each driver that
> needs to read an SLCR register.yes using regmap is also possible and I know that. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
signature.asc
Description: OpenPGP digital signature
