On Sat, 2014-10-11 at 14:39 +0530, Sudip Mukherjee wrote: > On Sat, Oct 11, 2014 at 03:20:56PM +0800, Raymond Yau wrote: > > > > > > pr_* macros replaced with dev_* as they are more preffered over pr_*. > > > each file which had pr_* was reviewed manually and replaced with dev_*. > > > here we have actually used the reference of the vortex which was added > > > to some functions in the previous patch of this series. > > > > > > The prefix of the CARD_NAME and prefix of "vortex:" was also > > > removed as the dev_* will print the device name. > > > > > > Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> > > > --- > > > > > > > > static int vortex_core_init(vortex_t *vortex) > > > { > > > > > > - pr_info( "Vortex: init.... "); > > > + dev_info(vortex->card->dev, "init.... "); > > > > Is it possible to add linefeed since "done/n" won't appear in the same > > line with init nor shutdown? > > > should we add linefeed ? > as of now it will print init.... then it will print done as the init is > complete. > so dmesg will show us: > > init....done. > > same for shutdown. > but if we give linefeed , then it will become : > > init.... > done. > > the meaning will be lost. and many user might just wonder what is done ? [] > > > @@ -2738,7 +2744,7 @@ static int vortex_core_init(vortex_t *vortex) > > > static int vortex_core_shutdown(vortex_t * vortex) > > > { > > > > > > - pr_info( "Vortex: shutdown..."); > > > + dev_info(vortex->card->dev, "shutdown..."); > > > #ifndef CHIP_AU8820 > > > vortex_eq_free(vortex); > > > vortex_Vort3D_disable(vortex); > > > @@ -2760,7 +2766,7 @@ static int vortex_core_shutdown(vortex_t * vortex) > > > msleep(5); > > > hwwrite(vortex->mmio, VORTEX_IRQ_SOURCE, 0xffff); > > > > > > - pr_info( "done.\n"); > > > + dev_info(vortex->card->dev, "done.\n"); > > > return 0; > > > }
It's actually on 2 lines before your patch. pr_info("a"); pr_info("b\n"); already emits 2 separate lines. pr_info("a"); pr_cont("b\n"); emits a single line "ab" (unless some other thread emits something in-between) pr_cont or a bare printk can be used after a dev_info without a newline to avoid unwanted newlines. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/