[PATCH 1/1 linux-next] fs/affs/amigaffs.c: use va_format instead of buffer/vnsprintf

[Fabian Frederick]

Remove ErrorBuffer and use %pV

Cc: Joe Perches <j...@perches.com>
Cc: Andrew Morton <a...@linux-foundation.org>
Signed-off-by: Fabian Frederick <f...@skynet.be>
---
 fs/affs/amigaffs.c | 28 +++++++++++++---------------
 1 file changed, 13 insertions(+), 15 deletions(-)

diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c
index abc8539..9643bdd 100644
--- a/fs/affs/amigaffs.c
+++ b/fs/affs/amigaffs.c
@@ -10,8 +10,6 @@
 
 #include "affs.h"
 
-static char ErrorBuffer[256];
-
 /*
  * Functions for accessing Amiga-FFS structures.
  */
@@ -444,30 +442,30 @@ mode_to_prot(struct inode *inode)
 void
 affs_error(struct super_block *sb, const char *function, const char *fmt, ...)
 {
-       va_list  args;
-
-       va_start(args,fmt);
-       vsnprintf(ErrorBuffer,sizeof(ErrorBuffer),fmt,args);
-       va_end(args);
+       struct va_format vaf;
+       va_list args;
 
-       pr_crit("error (device %s): %s(): %s\n", sb->s_id,
-               function,ErrorBuffer);
+       va_start(args, fmt);
+       vaf.fmt = fmt;
+       vaf.va = &args;
+       pr_crit("error (device %s): %s(): %pV\n", sb->s_id, function, &vaf);
        if (!(sb->s_flags & MS_RDONLY))
                pr_warn("Remounting filesystem read-only\n");
        sb->s_flags |= MS_RDONLY;
+       va_end(args);
 }
 
 void
 affs_warning(struct super_block *sb, const char *function, const char *fmt, 
...)
 {
-       va_list  args;
+       struct va_format vaf;
+       va_list args;
 
-       va_start(args,fmt);
-       vsnprintf(ErrorBuffer,sizeof(ErrorBuffer),fmt,args);
+       va_start(args, fmt);
+       vaf.fmt = fmt;
+       vaf.va = &args;
+       pr_warn("(device %s): %s(): %pV\n", sb->s_id, function, &vaf);
        va_end(args);
-
-       pr_warn("(device %s): %s(): %s\n", sb->s_id,
-               function,ErrorBuffer);
 }
 
 bool
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/