On Tue, 2014-10-14 at 18:44 +0200, Fabian Frederick wrote:
> See commit fbdb8138cf0c
> ("checkpatch: warn on uses of __constant_<foo> functions")
Perhaps it'd be better to use the same
__builtin_constant_p test as swab.h and use
just one pattern instead
> diff --git a/fs/jffs2/nodelist.h b/fs/jffs2/nodelist.h
> index fa35ff7..9f0d547 100644
> --- a/fs/jffs2/nodelist.h
> +++ b/fs/jffs2/nodelist.h
> @@ -48,8 +48,8 @@
> #define cpu_to_je32(x) ((jint32_t){cpu_to_be32(x)})
> #define cpu_to_jemode(x) ((jmode_t){cpu_to_be32(os_to_jffs2_mode(x))})
>
> -#define constant_cpu_to_je16(x) ((jint16_t){__constant_cpu_to_be16(x)})
> -#define constant_cpu_to_je32(x) ((jint32_t){__constant_cpu_to_be32(x)})
> +#define constant_cpu_to_je16(x) ((jint16_t){cpu_to_be16(x)})
> +#define constant_cpu_to_je32(x) ((jint32_t){cpu_to_be32(x)})
So none of these constant_<foo> things would be here
at all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
