> > > @@ -76,7 +76,7 @@ static ssize_t power_supply_show_property(struct device
> > > *dev,
> > > if (off == POWER_SUPPLY_PROP_TYPE) {
> > > value.intval = psy->type;
> > > } else {
> > > - ret = psy->get_property(psy, off, &value);
> > > + ret = power_supply_get_property(psy, off, &value);
> > >
> >
> > One thing.. Your power_supply_get_property (and friends) check for psy
> > == NULL. Is it neccessary / good idea? As far as I can tell, it should
> > not really be NULL...
>
> It is not necessary. I thought it would be a good behavior of such
> exported function. You're right that this shouldn't be NULL especially
> because previously it was dereferenced.
>
> Other existing power supply exported functions don't check this so maybe
> I shouldn't introduce inconsistency.
>
> I'll remove the check and re-spin. I'll found ugly typos in commit
> message anyway.
Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
