Re: [PATCH 1/2] spi/rockchip: fix bug that case spi can't go as fast as slave request

[Mark Brown]

On Wed, Oct 15, 2014 at 07:25:49PM +0800, Addy Ke wrote:

> +     if (WARN_ON(rs->speed > MAX_SCLK_OUT))
> +             rs->speed = MAX_SCLK_OUT;
> +
> +     /* the minimum divsor is 2 */
> +     if (rs->max_freq < 2 * rs->speed) {
> +             clk_set_rate(rs->spiclk, 2 * rs->speed);
> +             rs->max_freq = clk_get_rate(rs->spiclk);
> +     }

I'll apply this but you should be checking the return code from
clk_set_rate() here, please send a followup patch doing that.  It might
also be worth consdering just setting the rate unconditionally here, it
seems like it should make things simpler.

signature.asc
Description: Digital signature