On Wed, 15 Oct 2014 12:32:08 -0700 Joe Perches <[email protected]> wrote:
> Using weak can have unintended link defects.
> Emit an error on its use.
Well, we don't want a warning about use of __weak in function
definitions. Only in declarations.
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4671,6 +4671,14 @@ sub process {
> }
> }
>
> +# Check for __attribute__ weak, or __weak (may have link issues)
> + if ($realfile !~ m@\binclude/uapi/@ &&
And this bit maybe is checking for use in a header file, which is not
as good as checking for a declaration but is probably good enough.
However the "uapi" bit is confusing.
Can we have a better changelog please?
> + ($line =~ /\b__attribute__\s*\(\s*\(.*\bweak\b/ ||
> + $line =~ \b__weak\b/)) {
> + ERROR("AVOID_WEAK",
> + "Using weak can have unintended link defects" .
> $herecurr);
> + }
> +
> # check for sizeof(&)
> if ($line =~ /\bsizeof\s*\(\s*\&/) {
> WARN("SIZEOF_ADDRESS",
> --
> 2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
