On Wed, Oct 15, 2014 at 10:06 AM, Bjorn Helgaas <[email protected]> wrote: > > kernel/debug/debug_core.c provides a default kgdb_arch_pc() definition > explicitly marked "weak". Several architectures provide their own > definitions intended to override the default, but the "weak" attribute on > the declaration applied to the arch definitions as well, so the linker > chose one based on link order (see 10629d711ed7 ("PCI: Remove __weak > annotation from pcibios_get_phb_of_node decl")). > > Remove the "weak" attribute from the declaration so we always prefer a > non-weak definition over the weak one, independent of link order. > > Fixes: 688b744d8bc8 ("kgdb: fix signedness mixmatches, add statics, add > declaration to header") > Signed-off-by: Bjorn Helgaas <[email protected]> > CC: Harvey Harrison <[email protected]>
Reviewed-by: Harvey Harrison <[email protected]> This was likely simply an error in my patch, likely just copied the function definition and didn't even notice the weak annotation at the time. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
