On Thu, 2014-10-16 at 18:27 +0530, Sudip Mukherjee wrote: > On Thu, Oct 16, 2014 at 02:38:53AM -0700, Joe Perches wrote: > > On Thu, 2014-10-16 at 12:36 +0300, Ionut Alexa wrote: > > > Fixed codin style errors and warnings. Changes printk with > > > print_debug/warn. Changed seq_printf to seq_puts. > > If you are going to do style cleanups, please make > > sure you check your patches with scripts/checkpatch.pl > > before sending them. [] > should we be doing style cleanups in the kernel files ?
Generally, no. > previously i saw comments discouraging it as it pollutes the git blame. Also generally, style only patches are discouraged but can be done as part of a series when enhancements, bug-fixes or optimizations are done. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/