On Tue, 2014-10-21 at 11:47 +0200, Cyrille Pitchen wrote: > thanks for your comment. Indeed using print_hex_dump() would be a good idea > since it would avoid each driver to implement its own version of buffer dumps. > Reading the source code of print_hex_dump(), the output format would change a > little bit: > the output would no longer be aligned to JFFS2_BUFDUMP_BYTES_PER_LINE boundary > using leading spaces. > If it's ok to change the output format it's good for me as well.
Changing format is OK, this is just a debugging cruft. But it is OK only if you test the changes. If you are unable to test the changes, it is better to avoid doing non-trivial changes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
