> However, without needing the global tty_mutex held, the tty locks for > the releasing tty can now be held through the sleep. The sanity check > is for abnormal conditions caused by kernel bugs, not for recoverable > errors caused by misbehaving userspace; dropping the tty locks only > allows the tty state to get more sideways.
An open with O_NDELAY on the closing port now appears to be able to jam for 2 minutes ? Peviously it would at least be released by a signal. That seems like a regression (and given the timeout is long) a bug. Given that some code handles multiple tty devices using select and nonblocking opens on physical ports this one bothers me a little. The old behaviour wasn't right either (and actually stops Linux running some modem manager type tools), but the new behaviour looks worse. Probably though the right way to fix it is in the open path ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
