On 10/22/2014 09:40 PM, Florian Fainelli wrote:
2014-10-22 21:03 GMT-07:00 Guenter Roeck <li...@roeck-us.net>:
Add support for reading switch registers with 'ethtool -d'.
Signed-off-by: Guenter Roeck <li...@roeck-us.net>
---
[snip]
+static int dsa_slave_get_regs_len(struct net_device *dev)
+{
+ struct dsa_slave_priv *p = netdev_priv(dev);
+ struct dsa_switch *ds = p->parent;
+
+ if (ds->drv->get_regs_len != NULL)
+ return ds->drv->get_regs_len(ds, p->port);
Most of the checks in this file are just:
if (ds->drv->callback)
return ds->drv->callback(...)
Hi Florian,
To be fair, that wasn't the case when I wrote the code ;-).
No problem, I'll do the same.
+
+ return -EOPNOTSUPP;
+}
+
+static void
+dsa_slave_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *_p)
+{
+ struct dsa_slave_priv *p = netdev_priv(dev);
+ struct dsa_switch *ds = p->parent;
+
+ ds->drv->get_regs(ds, p->port, regs, _p);
We need to check that the driver does implement this callback here as well.
Obviously, and embarrassing ;-).
Thanks a lot for the review!
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
