On Sun, Apr 03, 2005 at 10:14:27PM +1000, herbert wrote: > > I personally don't see a reason why we should allow it to > continue when the codec doesn't exist. What do you guys think?
Actually, anybody trying to use this driver without a codec would've hit the same crash. Since nobody has complained before, we should just fail the registration if there is no codec. Then we can get rid of all the existing codec != NULL checks. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/