On 2014/10/27 16:04, Srikar Dronamraju wrote: > * Yao Dongdong <yaodongd...@huawei.com> [2014-10-27 11:13:17]: > >> Idle cpu is idler than non-idle cpu, so we needn't loop non-idle cpus after >> find an idle cpu. >> > While this check looks good, > I dont see how we are avoiding a loop? > > Are you suggesting that we break of the for loop once we set > shallowest_idle_cpu? > Thanks for your review.
I agree that the submit message is a bit misleading, what this patch do is just avoiding search for least_loaded_cpu in non-idle cpus. sched:add check of shallowest_idle_cpu before search for least_loaded_cpu Idle cpu is idler than non-idle cpu, so we needn't search for least_loaded_cpu after we have found an idle cpu. what about this? Thanks, Yao Dongdong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/