This slightly changes the behaviour of miscdevice drivers at an open() syscall. Not only if the driver happens to implement an open() fop itself, but now just always file->private_data points to struct miscdevice, when a user opens the device file.
This call for review once more: if anybody has an hour to kill: Look for the only dangerous situation where a miscdevice driver _depends_ on file->private_data being NULL when _not_ implementing an open() routine itself. I didn't find anything. The one section I was unsure about should be ok, see http://marc.info/?l=linux-kernel&m=141376535132316&w=2 Bonus: one could look for drivers that _do_ implement open() and do the (in any case) redundant work themselves. Martin Kepplinger (3): misc: always assign miscdevice to file->private_data in open() fbdev: pxa3xx-gcu: remove redundant implementation of open() char: misc: document behaviour of open() drivers/char/misc.c | 6 ++++-- drivers/video/fbdev/pxa3xx-gcu.c | 10 ---------- 2 files changed, 4 insertions(+), 12 deletions(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
