On Wed, 2014-10-29 at 19:42 -0400, Steven Rostedt wrote: > On Wed, 29 Oct 2014 15:08:36 -0700 Joe Perches <[email protected]> wrote: > > On Wed, 2014-10-29 at 17:56 -0400, Steven Rostedt wrote: > > > +A true return from seq_has_overflowed means that the seq_file buffer is > > > full > > > +and further output will be discarded. > > Perhaps the description is a bit unclear here. > > Doesn't a return of true to seq_has_overflowed mean that > > more characters have already been written than the buffer > > can accept? > Actually, right now the comment is correct and the name is misleading. > But I have a patch that will make the comment incorrect (and will be > fixed) and the name correct. > > But since seq_has_overflowed() is to be used throughout the kernel, I > didn't want to have to go do patches all over again for a temporary > misnomer.
I think it'd be better if the first submission of the function has the correct operation for the name. > In other words, I'm going to change the function to really return only > if it did overflow and not just be full. But that's another patch set > to come. Why would it be a set and not a single patch? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
