On Thu, Oct 30, 2014 at 10:00:35AM +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.b...@intel.com>
> 
> The ENABLE_DEV_COREDUMP option is misleading as it implies that
> it gets the framework enabled, this isn't true it just allows it
> to get enabled if a driver needs it.
> 
> Rename it to ALLOW_DEV_COREDUMP to better capture its semantics.

Sounds much better!

Acked-by: Aristeu Rozanski <a...@redhat.com>

> 
> Signed-off-by: Johannes Berg <johannes.b...@intel.com>
> ---
>  drivers/base/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index 99d30729d11e..e9f96afe920d 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -171,8 +171,8 @@ config WANT_DEV_COREDUMP
>         Drivers should "select" this option if they desire to use the
>         device coredump mechanism.
>  
> -config ENABLE_DEV_COREDUMP
> -     bool "Enable device coredump" if EXPERT
> +config ALLOW_DEV_COREDUMP
> +     bool "Allow device coredump" if EXPERT
>       default y
>       help
>         This option controls if the device coredump mechanism is available or
> @@ -187,7 +187,7 @@ config ENABLE_DEV_COREDUMP
>  config DEV_COREDUMP
>       bool
>       default y if WANT_DEV_COREDUMP
> -     depends on ENABLE_DEV_COREDUMP
> +     depends on ALLOW_DEV_COREDUMP
>  
>  config DEBUG_DRIVER
>       bool "Driver Core verbose debug messages"
> -- 
> 2.1.0
> 
> 

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to