On Sat, 2014-11-01 at 15:44 +0000, Steven Honeyman wrote:
> A 2 line printk makes dmesg output messy, because the second line does not
> get a timestamp.
> For example:
[]
> diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
[]
> @@ -487,10 +487,8 @@ static void init_intel(struct cpuinfo_x86 *c)
>
> rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
> if ((epb & 0xF) == ENERGY_PERF_BIAS_PERFORMANCE) {
> - printk_once(KERN_WARNING "ENERGY_PERF_BIAS:"
> - " Set to 'normal', was 'performance'\n"
> - "ENERGY_PERF_BIAS: View and update with"
> - " x86_energy_perf_policy(8)\n");
> + pr_info_once("ENERGY_PERF_BIAS: Set to 'normal', was
> 'performance'\n");
> + pr_info_once("ENERGY_PERF_BIAS: View and update with
> x86_energy_perf_policy(8)\n");
This changes the logging level.
You should either mention why in the changelog
or use pr_warn_once
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
