On Mon, Nov 03, 2014 at 09:47:40AM -0800, Joe Perches wrote: > On Mon, 2014-11-03 at 11:46 -0500, Jonathan Corbet wrote: > > On Wed, 29 Oct 2014 11:15:17 -0700 > > Josh Triplett <j...@joshtriplett.org> wrote: > > > > > Document several common practices and conventions regarding conditional > > > compilation, most notably the preference for ifdefs in headers rather > > > than .c files. > > > > OK, I've picked this one up for my 3.19 docs pull. > > I think that Al Viro's suggestion from awhile ago: > > https://lkml.org/lkml/2013/3/20/388 > > could still be in CodingStyle somewhere or in > another document like CodingStyleSuggestions.
I think that text needs some cleanup to better fit CodingStyle, but the intent and recommendations definitely ought to go in. A few of those seem too far down the road of "don't stuff beans up your nose", and some of them need shortening (just "don't put an else after an if condition ending with break or return; remember to handle errors via break, return, or continue, and outdent the subsequent code"). > Another thing that could go is the suggestion to > use Lindent. > > https://lkml.org/lkml/2013/2/11/390 Agreed completely. We might consider coming up with settings for clang-format, which seems like a far more capable replacement that actually understands C. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
