On Mon, 2014-11-03 at 11:51 -0600, Aravind Gopalakrishnan wrote: > On 11/3/2014 11:05 AM, Aravind Gopalakrishnan wrote: > > > > There are three ways that have been used to report machine check event. > > And they are MCE, CMCI/Threshold Interrupt, and POLL. On the Intel > > platform, CMCI/Threshold Interrupt and POLL share the same event handler > > - machine_check_poll(). However, on the AMD platform, they have a > > separate event handler. amd_threshold_interrupt() is used for handling > > Threshold Interrupt event. And machine_check_poll() has been used for > > polling other events. > > > > This patch introduces a new flag MCJ_INTERRUPT that will be used to > > separate CMCI/Threshold Interrupt and POLL handler in mce-inject. > > > > Signed-off-by: Chen Yucong <[email protected] <mailto:[email protected]>> > > --- > > arch/x86/include/asm/mce.h | 5 +++-- > > arch/x86/kernel/cpu/mcheck/mce-inject.c | 16 ++++++++++++++++ > > arch/x86/kernel/cpu/mcheck/threshold.c | 1 + > > 3 files changed, 20 insertions(+), 2 deletions(-) > > > > > We currently test decoding logic on AMD by performing mce injections > using edac/mce_amd_inj.c, > So instead of modifying mce-inject just for testing > amd_threshold_interrupt(), > Why not put it under mce_amd_inj? (It's AMD specific code anyway) > Until now, edac/mce_amd_inj.c is just used for testing EDAC decoding logic on AMD. But there are some tools that can be also used to decode machine check error information, such as `rasdaemon' and `mcelog'. If we want to use mce_amd_inj.c for error injection, we may need to move it.
In addition, EDAC decoding logic does not need to access machine check specific `MSRs', so edac/mce_amd_inj.c can work well for error injection. Finally, amd_threshold_interrupt is AMD specific code, intel_threshold_interrupt is also Intel specific code. thx! cyc -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
