On Wed, 5 Nov 2014 18:06:05 +0100 Petr Mladek <[email protected]> wrote:
> On Tue 2014-11-04 10:52:47, Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" <[email protected]> > > > > The function bstr_printf() from lib/vsprnintf.c is only available if > > CONFIG_BINARY_PRINTF is defined. This is due to the only user currently > > being the tracing infrastructure, which needs to select this config > > when tracing is configured. Until there is another user of the binary > > printf formats, this will continue to be the case. > > > > Since seq_buf.c is now lives in lib/ and is compiled even without > > tracing, it must encompass its use of bstr_printf() which is used > > by seq_buf_printf(). This too is only used by the tracing infrastructure > > and is still encapsulated by the CONFIG_BINARY_PRINTF. > > > > Signed-off-by: Steven Rostedt <[email protected]> > > Please switch the order and do this change before moving to lib/. > IMHO, the current order would break bisecting when tracing is > disabled. I agree. I was being lazy and when my test broke, I added the update to test again. But to move this change to before the move, I need to monkey with the patch file. I'll move it before the move regardless. > > Otherwise, the change looks good in itself, so: > > Reviewed-by: Petr Mladek <[email protected]> Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
