On Fri, 2014-11-14 at 20:32 +0100, Fabian Frederick wrote: > On 14 November 2014 at 20:14 Joe Perches <j...@perches.com> wrote: > > On Fri, 2014-11-14 at 20:02 +0100, Fabian Frederick wrote: > > > On 14 November 2014 at 19:47 Joe Perches <j...@perches.com> wrote: > > > > On Fri, 2014-11-14 at 19:36 +0100, Fabian Frederick wrote: > > > > > kmalloc_array manages count*sizeof overflow. > > > > > > > > Fundamentally correct, but is this necessary or useful? > > > > sizeof(s8) isn't often going to be anything other than 1. > > > Absolutely, I thought it was a struct :) > > > > > > There must be a reason for so many cases though ... > > > > Some might be style symmetry for other sizeof(othertype) > > uses in the same paths, but most of them are just overkill > > or maybe lack of understanding. > 95% comes from drivers tree. I guess one patch to Greg would be enough.
I think it'd be better to send patches through the appropriate various maintainers Likely just using the 2nd level directory would be good enough $ git grep -E --name-only "\*\s*sizeof\s*\(\s*[us]8\s*\)" | \ cut -f1-2 -d"/" | uniq arch/arm drivers/acpi drivers/char drivers/gpu drivers/iio drivers/infiniband drivers/input drivers/md drivers/media drivers/mtd drivers/net drivers/power drivers/rtc drivers/thermal fs/compat_ioctl.c net/dsa > Are you interested in those patches or can I do them with some "Suggested-by" > ? Not really and no need. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/