2014-11-14 14:16 GMT-08:00 Dmitry Torokhov <d...@chromium.org>: > Return value of irq_of_parse_and_map() is unsigned int, with 0 > indicating failure, so testing for negative result never works. > > Signed-off-by: Dmitry Torokhov <d...@chromium.org>
Acked-by: Florian Fainelli <f.faine...@gmail.com> > --- > > Not tested, found by casual code inspection. > > drivers/irqchip/irq-bcm7120-l2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-bcm7120-l2.c > b/drivers/irqchip/irq-bcm7120-l2.c > index e7c6155..8eec8e1 100644 > --- a/drivers/irqchip/irq-bcm7120-l2.c > +++ b/drivers/irqchip/irq-bcm7120-l2.c > @@ -102,9 +102,9 @@ static int bcm7120_l2_intc_init_one(struct device_node > *dn, > unsigned int idx; > > parent_irq = irq_of_parse_and_map(dn, irq); > - if (parent_irq < 0) { > + if (!parent_irq) { > pr_err("failed to map interrupt %d\n", irq); > - return parent_irq; > + return -EINVAL; > } > > /* For multiple parent IRQs with multiple words, this looks like: > -- > 2.1.0.rc2.206.gedb03e5 > > > -- > Dmitry -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/