Thanks Adrian for helping clean up the driver. Wendy will integrate your patch into our source tree. Scott
________________________________ From: Adrian Bunk [mailto:[EMAIL PROTECTED] Sent: Sat 4/9/2005 1:04 PM To: Andrew Morton Cc: Kilau, Scott; linux-kernel@vger.kernel.org Subject: [2.6 patch] drivers/serial/jsm/: make 2 functions static ----- Forwarded message from Adrian Bunk <[EMAIL PROTECTED]> ----- Date: Sat, 2 Apr 2005 01:38:51 +0200 From: Adrian Bunk <[EMAIL PROTECTED]> To: [EMAIL PROTECTED], [EMAIL PROTECTED] Cc: linux-kernel@vger.kernel.org Subject: [2.6 patch drivers/serial/jsm/: make 2 functions static This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 2 Apr 2005 drivers/serial/jsm/jsm.h | 1 - drivers/serial/jsm/jsm_neo.c | 2 +- drivers/serial/jsm/jsm_tty.c | 4 +++- 3 files changed, 4 insertions(+), 3 deletions(-) --- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_neo.c.old 2005-04-02 00:20:17.000000000 +0200 +++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_neo.c 2005-04-02 00:20:34.000000000 +0200 @@ -688,7 +688,7 @@ /* * No locks are assumed to be held when calling this function. */ -void neo_clear_break(struct jsm_channel *ch, int force) +static void neo_clear_break(struct jsm_channel *ch, int force) { u64 lock_flags; --- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm.h.old 2005-04-02 00:20:44.000000000 +0200 +++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm.h 2005-04-02 00:20:54.000000000 +0200 @@ -393,7 +393,6 @@ int jsm_uart_port_init(struct jsm_board *); int jsm_remove_uart_port(struct jsm_board *); void jsm_input(struct jsm_channel *ch); -void jsm_carrier(struct jsm_channel *ch); void jsm_check_queue_flow_control(struct jsm_channel *ch); #endif --- linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_tty.c.old 2005-04-02 00:21:02.000000000 +0200 +++ linux-2.6.12-rc1-mm4-full/drivers/serial/jsm/jsm_tty.c 2005-04-02 00:21:18.000000000 +0200 @@ -31,6 +31,8 @@ #include "jsm.h" +static void jsm_carrier(struct jsm_channel *ch); + static inline int jsm_get_mstat(struct jsm_channel *ch) { unsigned char mstat; @@ -760,7 +762,7 @@ jsm_printk(IOCTL, INFO, &ch->ch_bd->pci_dev, "finish\n"); } -void jsm_carrier(struct jsm_channel *ch) +static void jsm_carrier(struct jsm_channel *ch) { struct jsm_board *bd; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/