(2014/11/18 13:51), Namhyung Kim wrote: > On Tue, 18 Nov 2014 07:09:02 +0900, Masami Hiramatsu wrote: >> (2014/11/17 12:17), Masami Hiramatsu wrote: >>> (2014/11/17 12:08), Namhyung Kim wrote: >>>> I prefer this too. But I'd like make the 'add' part a subcommand rather >>>> than option like we do in perf kmem/kvm/list/lock/mem/sched ... And it >>>> can handle multiple files at once. What about this? >>>> >>>> perf cache add [--elf|--sdt|--probe <spec>] <binary> [<binary>...] >>> >>> OK, that's good to me. And I think --elf/--sdt is meaningless. >>> Only --probe option is required, since we can scan the elf file to >>> add sdt cache when adding elf binary :) >> >> BTW, what should we do if we put the probe cache on current running kernel? >> >> perf cache add --probe <probe-spec> >> >> and have no binary argument, is it OK? > > Hmm.. what about passing /proc/kallsyms and/or /boot/vmlinux for that?
Yeah, but I think it is just optional (as same as perf probe's -k option), we can skip that too. > Now I found that we need to special-case the kallsyms non-ELF file :) So, I wonder that we'd better use "bu/ildid/dso" instead of "bu/ildid/elf". Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu...@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
