On Sat, Nov 22, 2014 at 01:56:28AM +0300, Alexey Khoroshilov wrote: > If xenvif_alloc() failes, netback_probe() reports success as well as > "online" uevent is emitted. It does not make any sense, but it just
Sorry, I don't follow. KOBJ_ONLINE event is not emitted in the event of xenvif_alloc fails, is it? > misleads users. > > The patch implements propagation of error code if xenvif creation fails. > This patch not only implements propagation of error code when xenvif creation fails, but also when xenbus_scanf fails. You can simply write "This patch implements propagation of error code for backend_create_xenvif". The rest of this patch looks good to me. Can you rewrite commit message and resubmit, thanks. Wei. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/