[EMAIL PROTECTED] (Jes Sorensen) wrote:
>
> Hi Andrew,
>
> This patch provides the generic allocator needed for the ia64 mspec
> driver. Any chance you could add it to the mm tree?
spose so. Glad it's Kconfigurable.
> +#ifdef CONFIG_GENERIC_ALLOCATOR
> + gen_pool_init();
> +#endif
Suggest you put a !CONFIG_GENERIC_ALLOCATOR stub in genpool.h, remove these
ifdefs.
> +# Generic allocator support is selected if needed
> +#
> +config GENERIC_ALLOCATOR
> + boolean
This will be turned on by some later patch, yes?
So will this code even be compiled in -mm? I guess allyesconfig will
enable it.
> +
> +struct gen_pool *alloc_gen_pool(int nr_chunks, int max_chunk_shift,
> + unsigned long (*fp)(struct gen_pool *),
> + unsigned long data)
Some API kerneldocs would be useful.
> + /*
> + * This is really an arbitrary limit, +10 is enough for
> + * IA64_GRANULE_SHIFT.
> + */
> + if ((max_chunk_shift > (PAGE_SHIFT + 10)) ||
> + ((max_chunk_shift < ALLOC_MIN_SHIFT) && max_chunk_shift))
> + return NULL;
Does this ia64ism restrict the usefulness of genalloc in any way, or is the
comment stale?
> + * Simple power of two buddy-like generic allocator.
> + * Provides naturally aligned memory chunks.
> + */
> +unsigned long gen_pool_alloc(struct gen_pool *poolp, int size)
> +{
> + int j, i, s, max_chunk_size;
> + unsigned long a, flags;
> + struct gen_pool_link *h = poolp->h;
> +
> + max_chunk_size = 1 << poolp->max_chunk_shift;
> +
> + if (size > max_chunk_size)
> + return 0;
> +
> + i = 0;
> + s = (1 << ALLOC_MIN_SHIFT);
> + while (size > s) {
> + s <<= 1;
> + i++;
> + }
roundup_pow_of_two()?
> +#if DEBUG
> + printk(KERN_DEBUG "gen_pool_alloc: s %02x, i %i, h %p\n", s, i, h);
> +#endif
dprintk?
> + j = i;
> +
> + spin_lock_irqsave(&poolp->lock, flags);
> + while (!h[j].next) {
> + if (s == max_chunk_size) {
> + struct gen_pool_link *ptr;
> + spin_unlock_irqrestore(&poolp->lock, flags);
> + ptr = (struct gen_pool_link
> *)poolp->get_new_chunk(poolp);
mabe get_new_chunk() should return void*, avoid the casting?
> +#if DEBUG
> + printk(KERN_DEBUG "gen_pool_alloc() splitting i %i j %i
> %x a %02lx\n", i, j, s, a);
> +#endif
You once sent me a rude email for putting a line >80 cols into acenic.c
> + return;
> +
> + i = 0;
> + while (size > s) {
> + s <<= 1;
> + i++;
> + }
roundup_pow_of_two()?
> + while (q->next && q->next != (struct gen_pool_link *)b) {
> + q = q->next;
> + }
braces?
> +int __init gen_pool_init(void)
> +{
> + printk(KERN_INFO "Generic memory pool allocator v1.0\n");
> + return 0;
Do we need the printk?
> +
> +EXPORT_SYMBOL(alloc_gen_pool);
> +EXPORT_SYMBOL(gen_pool_alloc);
> +EXPORT_SYMBOL(gen_pool_free);
Current style is usually to put the exports at the line after the
function's closing brace. I prefer that personally - it's easier to
locate.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
