On Fri, 28 Nov 2014, Masahiro Yamada wrote: > This line converts PHYS_OFFSET into PHYS_PFN_OFFSET. > It is better to use PAGE_SHIFT rather than the magic number 12. > > Signed-off-by: Masahiro Yamada <yamad...@jp.panasonic.com>
Acked-by: Nicolas Pitre <n...@linaro.org> > --- > > arch/arm/kernel/head.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S > index 664eee8..ecb7be8 100644 > --- a/arch/arm/kernel/head.S > +++ b/arch/arm/kernel/head.S > @@ -586,7 +586,7 @@ __fixup_pv_table: > add r5, r5, r3 @ adjust table end address > add r6, r6, r3 @ adjust __pv_phys_pfn_offset address > add r7, r7, r3 @ adjust __pv_offset address > - mov r0, r8, lsr #12 @ convert to PFN > + mov r0, r8, lsr #PAGE_SHIFT @ convert to PFN > str r0, [r6] @ save computed PHYS_OFFSET to > __pv_phys_pfn_offset > strcc ip, [r7, #HIGH_OFFSET] @ save to __pv_offset high bits > mov r6, r3, lsr #24 @ constant for add/sub instructions > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
