Hi Linus, Noted, while I continue to work on this IRQ feature, can I resend patch 1 and patch 2 (rebase to devel branch) in v5 thread so that you can pull them in first?
Regards, Rebecca > -----Original Message----- > From: Linus Walleij [mailto:linus.wall...@linaro.org] > Sent: 28 November, 2014 10:03 PM > To: Chang, Rebecca Swee Fun > Cc: Linux Kernel Mailing List; GPIO Subsystem Mailing List; Westerberg, Mika; > Denis Turischev; Alexandre Courbot > Subject: Re: [PATCHv4 3/3] gpio: sch: Enable IRQ support for Quark X1000 > > On Wed, Nov 26, 2014 at 5:48 AM, Chang Rebecca Swee Fun > <rebecca.swee.fun.ch...@intel.com> wrote: > > > ntel Quark X1000 GPIO controller supports interrupt handling for both > > core power well and resume power well. This patch is to enable the IRQ > > support and provide IRQ handling for Intel Quark X1000 GPIO-SCH device > > driver. > > > > This piece of work is derived from Dan O'Donovan's initial work for > > Quark X1000 enabling. > > > > Signed-off-by: Chang Rebecca Swee Fun > > <rebecca.swee.fun.ch...@intel.com> > > This is just adding handling of cascading interrupts from a GPIO chip as far > as I > can tell. We don't do that with local per-driver hacks anymore if there is no > special reason, we have helpers on gpiolib to handle this. > > Make your Kconfig select GPIOLIB_IRQCHIP and take it from there, look at how > other drivers using GPIOLIB_IRQCHIP are done. Read the documentation for > chained irqchips in Documentation/gpio/driver.txt > > Yours, > Linus Walleij N�����r��y����b�X��ǧv�^�){.n�+����{����zX����ܨ}���Ơz�&j:+v�������zZ+��+zf���h���~����i���z� �w���?�����&�)ߢf��^jǫy�m��@A�a��� 0��h���i
