On Tue, Apr 12, 2005 at 11:27:44PM -0400, Ricky Beam wrote: > As an outside observer, I think he's given you plenty of reason to not > include this "hack". You, however, appear to only want to make a mess.
Why do you consider it a mess, and what reason did you see? The jsm driver is an effort where people like Wen Xiong, Al Viro and me put in a lot of effort to make the piece of crap the digi driver was into something almost sane. Now we should limit it to a tiny subset of the supported hardware just because digi is full of crack? > This is entirely the attitude the denouncers of open source live for. It > shows the complete lake of respect for the wishes of the maintainer(s). While Scott wrote most of the original code that ended up in the jsm driver he's certainly not the maintainer in any sense. > they "give" you their code. (If it's already GPL'd, there's nothing legally > stopping the code from being included in the first place, so why must they > ask for and/or ok inclusion? Answer: good will within the community which > you are now pissing all over.) But the original code isn't technically suitable. > Am I the only one with his eyes open here? When I read the first reply from > Scott, I was thinking, "why not just make it a config option? What's the > big f***ing deal?" Make it a config option with help text pointing people > to the "better" driver with improved features and support for that board. > Or something as simple as "don't enable this if you're going to use this > other dirver." Because a config option is totally pointless. If Scott wants someone to use his driver he can that person to simply load that driver, there's absolutely no reason for us to cripple our drivers because some vendor has out of tree drivers. We don't remove support for card from tg3 just because Broadcom would prefer us to use their bcm5700 driver, or remove support for cards from the 3c59x driver just because 3com has a driver of their own for a few of those cards. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
