On 12/03/2014 05:01 AM, Thomas Petazzoni wrote:
> Michael, Tim,
>
> On Wed, 03 Dec 2014 14:43:11 +1100, Michael Ellerman wrote:
>
>>> diff --git a/tools/testing/selftests/size/Makefile
>>> b/tools/testing/selftests/size/Makefile
>>> new file mode 100644
>>> index 0000000..47f8e9c
>>> --- /dev/null
>>> +++ b/tools/testing/selftests/size/Makefile
>>> @@ -0,0 +1,15 @@
>>> +#ifndef CC
>>> + CC = $(CROSS_COMPILE)gcc
>>> +#endif
>>
>> I think the following is preferable:
>>
>> CC := $(CROSS_COMPILE)$(CC)
>
> It is even more necessary that #ifndef and #endif don't exist in make.
> They are just comments, and therefore, ignored. Seems like Tim does too
> much C :-)
OK - that's hilarious. Saying 'Oops!' would be too casual for my degree of
embarrassment. :-)
Makefiles do have similar constructs. Those should have been
ifeq ($(CC),)
...
endif
This obviously got through via a failiure in testing - which is somewhat ironic.
Look for a v6 soon. (Geez, when is the merge window coming. I thought this
trivial
program would get in pretty easily, but no... that's never the way. Of course
it helps if the submitter is not an idiot.)
-- Tim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
