2014-12-10 15:20 GMT+01:00 Guenter Roeck <[email protected]>: >> + case INA2XX_CALIBRATION: >> + if (data->regs[reg] == 0) >> + val = 0; >> + else >> + val = data->config->calibration_factor >> + / data->regs[reg]; >> + break; > > > This doesn't really make sense. What you want to show is rshunt, not the > above. > I think it would be better to write a separate show function to display it.
Hi Guenter, this is the only way to display values read from the chip. It also tells the user what the actual programmed value is. In fact it was your suggestion (https://lkml.org/lkml/2014/11/30/233) and I agree that it's a better alternative. Are you sure you don't want it done this way? Bart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
