Hi David,
On Fri, 15 Apr 2005 15:45:02 +0100 David Howells <[EMAIL PROTECTED]> wrote:
>
> @@ -746,10 +747,79 @@ static void *do_smb_super_data_conv(void
> return raw_data;
> }
>
> +struct compat_nfs_string {
> + compat_uint_t len;
> + compat_uptr_t __user data;
^^^^^^
This __user (and the others later) add nothing (I think) as compat_uptr_t is
generally just u32 and compat_ptr() does the right casting.Otherwise, the patch looks fine for a minimal fix. I agree with David and Bryan that we need to get the fs specific stuff out of compat.c in the longer term. -- Cheers, Stephen Rothwell [EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/
pgp8F35RpL9Xh.pgp
Description: PGP signature
