Yes, you're right, At first i thought that it is just typo, and right after that i thought about this case when somebody will change STACK_SIZE
2014-12-26 20:35 GMT+06:00 Jeremiah Mahler <jmmah...@gmail.com>: > Alexander, > > On Fri, Dec 26, 2014 at 06:22:42PM +0600, Alexander Kuleshov wrote: >> heap_end_ptr default value defined as _end+STACK_SZE-512, but > STACK_SIZE > >> STACK_SIZE is already 512. >> >> Signed-off-by: Alexander Kuleshov <kuleshovm...@gmail.com> >> --- >> arch/x86/boot/header.S | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S >> index 16ef025..c69b870 100644 >> --- a/arch/x86/boot/header.S >> +++ b/arch/x86/boot/header.S >> @@ -342,7 +342,7 @@ ramdisk_size: .long 0 # its size in >> bytes >> bootsect_kludge: >> .long 0 # obsolete >> >> -heap_end_ptr: .word _end+STACK_SIZE-512 >> +heap_end_ptr: .word _end >> # (Header version 0x0201 or later) >> # space from here (exclusive) down to >> # end of setup code can be used by >> setup > > So right now STACK_SIZE happens to be 512 so STACK_SIZE-512 is zero. > What happens if someone changes the size of STACK_SIZE? > > This change doesn't fix any problem right now and creates potential > problems in the future. > >> -- >> 2.2.1.201.gbbcefff >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > -- > - Jeremiah Mahler -- _________________________ 0xAX -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
