2014-12-28 6:57 GMT-08:00 Beniamino Galvani <b.galv...@gmail.com>: > Add support for Byte Queue Limits to the STMicro MAC driver. > > Tested on a Amlogic S805 Cortex-A5 board, where the use of BQL > slightly decreases the ping latency from ~10ms to ~3ms when the > 100Mbps link is saturated by TCP streams. No difference is > observed at 1Gbps. > > Signed-off-by: Beniamino Galvani <b.galv...@gmail.com> > ---
[snip] > priv->dev->stats.tx_errors++; > @@ -2049,6 +2057,7 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, > struct net_device *dev) > skb_tx_timestamp(skb); > > priv->hw->dma->enable_dma_transmission(priv->ioaddr); > + netdev_sent_queue(dev, skb->len); You are introducing a potential use after free here in case tx_lock is eliminated one day and your TX reclaim logic kicks in and frees the freshly transmitted SKB, it would be safer to just cache skb->len in a local variable, and use it here. > > spin_unlock(&priv->tx_lock); > return NETDEV_TX_OK; -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
