Hi Aaron, On 12/29/2014 03:32 AM, Wu, Aaron wrote: >> From: Oliver Hartkopp [mailto:[email protected]]
>> So the correct way is to check which defines are *really* referenced and add >> these directly to bfin_can.c (the only user) when removing bfin_can.h > > Thanks for reply, will merge your idea and be back. Great. As there's so many unused stuff in bfin_can.h I assume this to be a real good improvement. > Also your comments about another of my recent patch " Rewrite the blackfin > CAN driver into arch independent style" is welcome. This looks good to ME but usually Marc maintains the driver portions - and I don't really know if it just *looks* good or if it *is* good ;-) I just wanted to comment on the include file - as I knew the potential feedback from Marc there. For the rest we need to wait for Marc coming back from vacation. Best regards, Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
