On Mon, Dec 29, 2014 at 04:05:14PM +0000, Mark Brown wrote: > On Mon, Dec 29, 2014 at 10:59:08AM +0000, Zidan Wang wrote: > > Hi Mark, > > Don't top post and please fix your mailer to word wrap within paragraphs > and avoid corrupting the mail it's quoting. > > > You are right. When PM is disabled, the codec will not work. But there are > > also some codecs enable mclk in PM, such as wm8962, cs42xx8. > > And some codecs enable codec mclk in i2c probe(), startup() and > > set_bias_level(). It makes me confused. > > Can you tell me what's the general idiom to enable mclk. Thanks. > > Like I said in the mail to which you replied: > > > > This isn't going to work if PM is disabled (which is still a valid > > > configuration). The general idiom for this is that the driver should > > > start up with everything powered up then let runtime idle turn things off > > > if they're not required. That way if runtime PM is disabled then the > > > system will still work as everything will just stay powered on all the > > > time.
I want put mclk enable to set_bias_level. Do you thinks it make sense? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

