On Thu, Jan 01, 2015 at 01:59:13PM -0800, Stephen Hemminger wrote: > On Tue, 23 Dec 2014 17:46:54 +0200 > "Ahmed S. Darwish" <[email protected]> wrote: > > > int ret = NETDEV_TX_OK; > > + bool kfree_skb_on_error = true; > > > > if (can_dropped_invalid_skb(netdev, skb)) > > return NETDEV_TX_OK; > > @@ -1336,6 +1337,7 @@ static netdev_tx_t kvaser_usb_start_xmit(struct > > sk_buff *skb, > > > > if (!context) { > > netdev_warn(netdev, "cannot find free context\n"); > > + kfree_skb_on_error = false; > > ret = NETDEV_TX_BUSY; > > You already have a flag value (ret == NETDEV_TX_BUSY), why > not use that instead of introducing another variable?
Yes, that variable got implicitly removed in v2 patch 1/4. Thanks, -- Darwish -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
