From: Fabian Frederick <f...@skynet.be> Date: Sat, 3 Jan 2015 14:44:16 +0100
> -Avoid double goto and directly return err where possible. > -Remove unused labels which fixes: > > drivers/net/ethernet/hp/hp100.c:3047:2: warning: label > 'out3' defined but not used [-Wunused-label] > > Signed-off-by: Fabian Frederick <f...@skynet.be> > --- > This is untested. Having a sole lone return statement that all flows of control branch to makes the code easier to audit, than to have a huge block where each return statement has to be audited independently for potential cleanups. Added to the fact that this patch is completely untested, I'm not applying this, sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
