Flip the polarity of mapping_cap_account_dirty() test so that the body of page accounting can be moved outside the if () block. This will help adding cgroup writeback support.
This causes no logic changes. Signed-off-by: Tejun Heo <[email protected]> Cc: Jens Axboe <[email protected]> Cc: Jan Kara <[email protected]> Cc: Wu Fengguang <[email protected]> --- mm/page-writeback.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 026c91b..d73539f 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2094,15 +2094,16 @@ void account_page_dirtied(struct page *page, struct address_space *mapping) { trace_writeback_dirty_page(page, mapping); - if (mapping_cap_account_dirty(mapping)) { - __inc_zone_page_state(page, NR_FILE_DIRTY); - __inc_zone_page_state(page, NR_DIRTIED); - __inc_wb_stat(&mapping->backing_dev_info->wb, WB_RECLAIMABLE); - __inc_wb_stat(&mapping->backing_dev_info->wb, WB_DIRTIED); - task_io_account_write(PAGE_CACHE_SIZE); - current->nr_dirtied++; - this_cpu_inc(bdp_ratelimits); - } + if (!mapping_cap_account_dirty(mapping)) + return; + + __inc_zone_page_state(page, NR_FILE_DIRTY); + __inc_zone_page_state(page, NR_DIRTIED); + __inc_wb_stat(&mapping->backing_dev_info->wb, WB_RECLAIMABLE); + __inc_wb_stat(&mapping->backing_dev_info->wb, WB_DIRTIED); + task_io_account_write(PAGE_CACHE_SIZE); + current->nr_dirtied++; + this_cpu_inc(bdp_ratelimits); } EXPORT_SYMBOL(account_page_dirtied); -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
