Yingjoe, On Wed, Dec 10, 2014 at 05:55:02PM +0800, Yingjoe Chen wrote: > Beniamino reported a kernel oops caused by an invalid DT file for the > mediatek interrupt polarity extension. > > The reason is that the interrupt polarity support for mediatek chips > merely checks for NULL pointer instead of a casted error return > value in mtk_sysirq_of_init() so any other casted error value passes > the NULL pointer check and causes a kernel panic when dereferenced. > > Use IS_ERR() and return the error value via PTR_ERR(). > > Reported-and-tested-by: Beniamino Galvani <b.galv...@gmail.com> > Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> > --- > drivers/irqchip/irq-mtk-sysirq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
I applied V2 to irqchip/urgent, and hand-added the changes from V3 because the email formatting was wrong. I also tweaked the subject line. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
