On Thu, 2015-01-08 at 22:36 +0000, Colin King wrote:
> From: Colin Ian King <colin.k...@canonical.com>
>
> hwirq has not been initialized, however it is being incremented
> and also not being referenced in a loop. This error was detected with
> cppcheck:
>
> [drivers/misc/cxl/irq.c:439]: (error) Uninitialized variable: hwirq
>
> Commit 80fa93fce37d ("cxl: Name interrupts in /proc/interrupt")
> introduced this error.
>
> This is a simple fix that removes the redundant increment.
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Thanks. Looks good.
Acked-By: Michael Neuling <mi...@neuling.org>
> ---
> drivers/misc/cxl/irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c
> index c294925..68ab608 100644
> --- a/drivers/misc/cxl/irq.c
> +++ b/drivers/misc/cxl/irq.c
> @@ -436,7 +436,7 @@ int afu_register_irqs(struct cxl_context *ctx, u32 count)
> */
> INIT_LIST_HEAD(&ctx->irq_names);
> for (r = 1; r < CXL_IRQ_RANGES; r++) {
> - for (i = 0; i < ctx->irqs.range[r]; hwirq++, i++) {
> + for (i = 0; i < ctx->irqs.range[r]; i++) {
> irq_name = kmalloc(sizeof(struct cxl_irq_name),
> GFP_KERNEL);
> if (!irq_name)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
