From: Stefan Agner <ste...@agner.ch> Sent: Friday, January 09, 2015 4:22 PM
> To: Duan Fugang-B38611
> Cc: Bhuvanchandra DV; linux-kernel@vger.kernel.org; Zhou Luwei-B45643;
> l...@karo-electronics.de; Li Frank-B20596; da...@davemloft.net; u.kleine-
> koe...@pengutronix.de; shawn....@linaro.org
> Subject: RE: [PATCH] net: fec: Fix dual ethernet issue in VFxx
> 
> On 2015-01-09 04:00, fugang.d...@freescale.com wrote:
> > From: Stefan Agner <ste...@agner.ch> Sent: Friday, January 09, 2015
> > 2:59 AM
> >> To: Duan Fugang-B38611
> >> Cc: Bhuvanchandra DV; linux-kernel@vger.kernel.org; Zhou
> >> Luwei-B45643; l...@karo-electronics.de; Li Frank-B20596;
> >> da...@davemloft.net; u.kleine- koe...@pengutronix.de;
> >> shawn....@linaro.org
> >> Subject: RE: [PATCH] net: fec: Fix dual ethernet issue in VFxx
> >>
[snip]
> 
> Currently, MAC1 is broken in case 3 on Vybrid (as well as i.MX6XS and
> i.MX7, because the FEC_QUIRK_ENET_MAC is enabled for all of them).
> 
> > For all these cases, your above patches cannot handle these.
> 
> Yes, in it's current state, I agree. A new revision is required.
> 
> > So I still insist to add another property for this to avoid the
> > existing dts files change.
> 
> But I don't think adding another device tree property is helping here.
> There is already a device tree standard how to describe the MDIO buses,
> why not just make use of them?
> 
> I will create a v2 patchset, so we have a new base to discuss this
> further.
> 
Don't invent new property, and compatible with above four cases (avoid existing 
dts changing), it is difficult.
Looking forward to your next patchset.

Regards,
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to