Hello I think that only gpio-mpc5200.c would benefit from the new API, I can send a patchset to support removal and use the new API if you want.
Thanks! On Mon, Jan 12, 2015 at 10:30 AM, Linus Walleij <linus.wall...@linaro.org> wrote: > On Wed, Dec 17, 2014 at 4:51 PM, Ricardo Ribalda Delgado > <ricardo.riba...@gmail.com> wrote: > >> Create counterpart of of_mm_gpiochip_add(). This way the modules that >> can be removable do not duplicate the cleanup code. >> >> Suggested-by: Alexandre Courbot <gnu...@gmail.com> >> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> > > Patch applied. > > Hm. > > $ git grep of_mm_gpiochip_add > arch/powerpc/sysdev/cpm1.c: return of_mm_gpiochip_add(np, mm_gc); > arch/powerpc/sysdev/cpm1.c: return of_mm_gpiochip_add(np, mm_gc); > arch/powerpc/sysdev/cpm_common.c: return of_mm_gpiochip_add(np, mm_gc); > arch/powerpc/sysdev/ppc4xx_gpio.c: ret = > of_mm_gpiochip_add(np, mm_gc); > arch/powerpc/sysdev/qe_lib/gpio.c: ret = > of_mm_gpiochip_add(np, mm_gc); > arch/powerpc/sysdev/simple_gpio.c: ret = of_mm_gpiochip_add(np, mm_gc); > drivers/gpio/gpio-ge.c: return of_mm_gpiochip_add(pdev->dev.of_node, mmchip); > drivers/gpio/gpio-mm-lantiq.c: ret = > of_mm_gpiochip_add(pdev->dev.of_node, &chip->mmchip); > drivers/gpio/gpio-mpc5200.c: ret = > of_mm_gpiochip_add(ofdev->dev.of_node, &chip->mmchip); > drivers/gpio/gpio-mpc5200.c: ret = > of_mm_gpiochip_add(ofdev->dev.of_node, &chip->mmchip); > drivers/gpio/gpio-mpc8xxx.c: ret = of_mm_gpiochip_add(np, mm_gc); > drivers/gpio/gpio-xilinx.c: status = of_mm_gpiochip_add(np, > &chip->mmchip); > drivers/gpio/gpio-zevio.c: status = > of_mm_gpiochip_add(pdev->dev.of_node, &(controller->chip)); > > Should these all be patched to use this, or reviewed for applicability? > > Yours, > Linus Walleij -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
